Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: DeprecationWarning: The punycode module is deprecated #27156

Closed
valentinpalkovic opened this issue May 15, 2024 · 0 comments · Fixed by #28160
Closed

[Bug]: DeprecationWarning: The punycode module is deprecated #27156

valentinpalkovic opened this issue May 15, 2024 · 0 comments · Fixed by #28160

Comments

@valentinpalkovic
Copy link
Contributor

Describe the bug

Source: #27027 (comment)

Looks like you should also update your node-fetch version used in @storybook/core-common to load the transitive dep whatwg-url >= 9.0.0 and avoid the punycode deprecation warning.

morgan@machine:~/code/tts-react (develop)$ node --trace-deprecation ./node_modules/.bin/storybook info

Storybook Environment Info:
(node:50775) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:337:10)
    at loadBuiltinModule (node:internal/modules/helpers:104:7)
    at Module._load (node:internal/modules/cjs/loader:1075:17)
    at Module.require (node:internal/modules/cjs/loader:1310:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/home/morgan/code/tts-react/node_modules/node-fetch/node_modules/whatwg-url/lib/url-state-machine.js:2:18)
    at Module._compile (node:internal/modules/cjs/loader:1480:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1564:10)

  System:
    OS: Linux 6.8 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (12) x64 13th Gen Intel(R) Core(TM) i5-1335U
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 22.1.0 - ~/n/bin/node
    npm: 10.7.0 - ~/n/bin/npm <----- active
  Browsers:
    Chrome: 124.0.6367.118

morgan@machine:~/code/tts-react (develop)$ npm ls node-fetch
tts-react-monorepo@0.0.0 /home/morgan/code/tts-react
└─┬ story@1.0.0 -> ./packages/story
  └─┬ @storybook/react-webpack5@8.0.10
    └─┬ @storybook/builder-webpack5@8.0.10
      └─┬ @storybook/core-common@8.0.10
        └── node-fetch@2.7.0

morgan@machine:~/code/tts-react (develop)$ npm ls whatwg-url
tts-react-monorepo@0.0.0 /home/morgan/code/tts-react
├─┬ jest-environment-jsdom@29.5.0
│ └─┬ jsdom@20.0.3
│   ├─┬ data-urls@3.0.2
│   │ └── whatwg-url@11.0.0 deduped
│   └── whatwg-url@11.0.0
└─┬ story@1.0.0 -> ./packages/story
  └─┬ @storybook/react-webpack5@8.0.10
    └─┬ @storybook/builder-webpack5@8.0.10
      └─┬ @storybook/core-common@8.0.10
        └─┬ node-fetch@2.7.0
          └── whatwg-url@5.0.0
          ```

### To Reproduce

-

### System

```bash
-

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants