Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addDecorator in .storybook/config.js applied multiple times #284

Closed
Maxhodges opened this issue Jun 28, 2016 · 10 comments
Closed

addDecorator in .storybook/config.js applied multiple times #284

Maxhodges opened this issue Jun 28, 2016 · 10 comments
Labels

Comments

@Maxhodges
Copy link
Contributor

each time I save my story, the decorator is applied again i.e. while editing my story, if I save in my editor five times, it reloads the story in the browser, but the decorate is applied five times. Refreshing the browser will clear it.

image

@arunoda arunoda added the bug label Jun 29, 2016
@arunoda
Copy link
Member

arunoda commented Jun 29, 2016

Yep. This is a good call.
We need to stop applying decorators, if it's a HMR change.

@Maxhodges
Copy link
Contributor Author

for context, the decorator we used was in .storybook/config.js not directly in the story

https://github.com/white-rabbit-japan/Semantic-UI-React-Storybook/blob/master/.storybook/config.js#L5-L9

@thani-sh
Copy link
Contributor

@Maxhodges thanks for that info. It helped narrow down the issue.

@pcardune
Copy link
Contributor

+1 for fixing this issue

@robertvansteen
Copy link

Is there any progress on this? I've tried to create a workaround but no luck yet & I don't understand the code of storybook enough to create a pull request.

@thani-sh
Copy link
Contributor

Released v1.40.0 with a fix

@michael-martin
Copy link

Can confirm 1.4.0 is working great for us, thanks @mnmtanish :)

@ritz078
Copy link
Contributor

ritz078 commented Aug 14, 2016

@mnmtanish can be closed.

@thani-sh
Copy link
Contributor

Yeah, thanks

@macrozone
Copy link
Contributor

I got still the same error on react-native. any idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants