Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter Full Screen mode without a keyboard #314

Closed
aray12 opened this issue Jul 15, 2016 · 9 comments
Closed

Enter Full Screen mode without a keyboard #314

aray12 opened this issue Jul 15, 2016 · 9 comments

Comments

@aray12
Copy link

aray12 commented Jul 15, 2016

I'd love to be able to test certain items on my phone, but I can't enter full screen without the keyboard. I know I can test most items by just resizing the window, but I'd also like to test how certain items look with a keyboard taking up 1/3 of the screen etc.

Thoughts?

@arunoda
Copy link
Member

arunoda commented Jul 15, 2016

Yeah I know. This is a pain. We will need to implement a mobile UI.

@arunoda arunoda added the bug label Jul 15, 2016
@arunoda
Copy link
Member

arunoda commented Jul 15, 2016

cc @mnmtanish

@arunoda arunoda added the ui label Jul 15, 2016
@aray12
Copy link
Author

aray12 commented Jul 15, 2016

Do you want me to repost in storybook-ui? After some digging, I realize now that is the repo where this change would happen. I don't think the problem is getting into fullscreen (make the icon in the popup a button) but then getting back out

@arunoda
Copy link
Member

arunoda commented Jul 20, 2016

@aray12 Good question. May be we need to support the shake event or a long press event on the screen.

@aray12
Copy link
Author

aray12 commented Aug 15, 2016

After some thought, it might be a good idea to completely rethink the approach for mobile. Responsive development is only becoming more important and in a perfect world I would see my components in both desktop and mobile (using something like browser-sync) simultaneously as I build for the basic visual testing. I noticed in #378 that you use storybook to match design which is exactly how we use it as well. But the mobile experience is lacking in storybook

  1. the use of shortcuts means that browser-sync cannot keep them in sync (it syncs clicks)
  2. the iframe has broken some of my css in mobile (banging my head over a bug that was gone as soon as I used the component in the actual app)
  3. UI just wasn't built for mobile

I love using storybook and it has tremendously improved productivity and transparency, but I have found myself considering building a custom implementation. But that would take a bit of work to be as useful. One idea I had was, what if you guys extracted the logic that pulls together all of the stories into its own package so that people could build their own UI on top of that.

Pros

  1. People could have their own branded version
  2. No need for iframes

Con

  1. Not as plug and play as the current setup

This is obviously not fully thought through. The point is rethinking approach for mobile. Any thoughts? Also how do you guys dev for mobile?

@Gnito
Copy link

Gnito commented Sep 23, 2016

Iframe certainly is problematic with Storybook. To me it would make more sense to

  1. have general page with navigation column where React components are rendered to some container (main column)
  2. have component specific page (pure component -> i.e. what currently is shown inside iframe).

-> addon related info etc. should be showed on off-screen canvas.
CSS Modules should help if someone is afraid that styles might affect each others.

@usulpro usulpro self-assigned this Apr 6, 2017
@ndelangen ndelangen removed the ui label Apr 12, 2017
@usulpro usulpro added the ui label Apr 22, 2017
@usulpro
Copy link
Member

usulpro commented Apr 22, 2017

It could be solved by adding this #867 feature.
At the moment I'm working on moving storybook-eol/storybook-ui#69 into a monorepo

@stale
Copy link

stale bot commented Oct 31, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. We do try to do some housekeeping every once in a while so inactive issues will get closed after 90 days. Thanks!

@stale stale bot added the inactive label Oct 31, 2017
@stale
Copy link

stale bot commented Nov 2, 2017

Hey there, it's me again! I am going to help our maintainers close this issue so they can focus on development efforts instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants