Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support ui-related query params in addon-links #3787

Closed
jfsiii opened this issue Jun 22, 2018 · 8 comments
Closed

Feature request: Support ui-related query params in addon-links #3787

jfsiii opened this issue Jun 22, 2018 · 8 comments

Comments

@jfsiii
Copy link
Contributor

jfsiii commented Jun 22, 2018

related to #1739

The storybook URL has query params to put the UI in a particular state, (e.g. nav/addon panel appearance, position, focus, etc), but addon-links only supports the selectedStory and selectedKind params (via story & kind).

e.g. story with no panels shown and same story w/background panel shown & focused

I'd like everything that is available in the URL to be available to hrefTo and/or <LinkTo/>

This way one story could link to another story in a particular state. e.g.

e.g.

<LinkTo
  kind="Components|Form/Button"
  story="with onclick"
  addons
  stories=0 // or `false`, etc
  panelRight=0 // or `false`, etc
  addonPanel="storybook-addon-background/background-panel"
>Story with background panel focused</LinkTo>

would produce a relative URL like

?selectedKind=Components%7CForm%2FButton&selectedStory=with%20onclick&full=0&addons=1&stories=0&panelRight=0&addonPanel=storybook-addon-background%2Fbackground-panel
@stale
Copy link

stale bot commented Jul 14, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 14, 2018
@arshadkazmi42
Copy link

I would like to take this up.

@stale stale bot removed the inactive label Aug 13, 2018
@igor-dv
Copy link
Member

igor-dv commented Aug 16, 2018

@arshadkazmi42 feel free to PR.

@arshadkazmi42
Copy link

@igor-dv I tried tracking the component down. But unable to pass the props to url. Can you guide me through, where exactly this is handled?

@ndelangen
Copy link
Member

I'll see what I can do, I need to fix addon-links in #4086 anyway

@stale
Copy link

stale bot commented Oct 18, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Oct 18, 2018
@stale
Copy link

stale bot commented Nov 17, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@airtonix
Copy link

what happened with this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants