Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook doesn't run when --dont-track flag is included #395

Closed
necolas opened this issue Aug 22, 2016 · 5 comments
Closed

Storybook doesn't run when --dont-track flag is included #395

necolas opened this issue Aug 22, 2016 · 5 comments
Labels

Comments

@necolas
Copy link
Contributor

necolas commented Aug 22, 2016

We added --dont-track to our storybook script:

start-storybook --dont-track -p 9001 -c /path-to/storybook-dir

Result:

Storybook starting...
Storybook would not send anonymous usage stats anymore.

And the process exits.

@necolas
Copy link
Contributor Author

necolas commented Aug 22, 2016

Looking through the tracking patch, it looks like this is the intended behaviour. Really confusing decision and API, IMO.

@arunoda
Copy link
Member

arunoda commented Aug 23, 2016

[EDITED]

Actually, you need to do this only once. After that, there's no need to use don't track command.
We wanted to make the remove tracking in a single command forever.

But you've a point specially when working with a team.
I think we'll work with something without exiting the process.

@arunoda arunoda added the bug label Aug 23, 2016
@necolas
Copy link
Contributor Author

necolas commented Aug 23, 2016

Oh I see. So you'd expect storybook to be installed globally in that case? In my case we have a tool like create-react-app that bundles storybook and wraps commands. So the storybook script now runs 2 start-storybook commands. No problem

@arunoda
Copy link
Member

arunoda commented Aug 23, 2016

@necolas ah nope. It's the same command you install in your project. Anyway, this is confusing.
I'll change it as you expected it to work.
That makes sense.

@necolas
Copy link
Contributor Author

necolas commented Aug 23, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants