Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-preset-vue missing as peer dependency #4505

Closed
y-nk opened this issue Oct 22, 2018 · 3 comments
Closed

babel-preset-vue missing as peer dependency #4505

y-nk opened this issue Oct 22, 2018 · 3 comments

Comments

@y-nk
Copy link
Contributor

y-nk commented Oct 22, 2018

Steps to reproduce

In a new directory :

  1. basic install : npm i --save-dev @storybook/vue@rc

  2. peer dependencies from storybook : npm i --save-dev babel-loader vue-loader vue-template-compiler && npm i --save vue

  3. package related peer dependencies: npm i --save-dev @babel/core

  4. add run script to package.json :

"scripts" {
+  "storybook": "start-storybook -p 9001 -c .storybook"
},

5a. minimal .storybook/config.js :

import { configure } from '@storybook/vue';

configure(() => {
  require('../stories')
}, module);

5b. minimal entrypoint with demo :

import { storiesOf } from '@storybook/vue';

storiesOf('demo', module)
  .add('...', () => ({
    template: '<span>hello world</span>',
  }));

Now it's time to run :

> start-storybook -p 9001 -c .storybook

info @storybook/vue v4.0.0-rc.1
info
(node:16619) ExperimentalWarning: The fs.promises API is experimental
info => Loading presets
ERR! Error: Cannot find module 'babel-preset-vue'

To fix it : add babel-preset-vue as peer dependency in @storybook/vue/package.json

Meanwhile : npm i --save-dev babel-preset-vue

@igor-dv
Copy link
Member

igor-dv commented Oct 22, 2018

Thanks. It's duplicate to #4475

@y-nk
Copy link
Contributor Author

y-nk commented Jun 26, 2019

@igor-dv installing latest @storybook/vue@5.1.9 this is still a valid bug

@shilman
Copy link
Member

shilman commented Jun 26, 2019

@y-nk but it's a dupe to #4475 so let's solve it there?

@shilman shilman closed this as completed Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants