Navigation order breaks during hot reload

[jzaefferer]

To reproduce: Start with 3 stories, A, B, C. By default, they're alphabetically ordered. Now edit story A. After a hot reload, observe the navigation order.

Expected: A, B, C
Actual: B, C, A

It seems like the hot reloaded story gets stuck to the end of the list. After a hard reload of the page, its back where its supposed to be.

Tested with 2.18.0.

PS: The "Known Issues" link in https://github.com/kadirahq/react-storybook/blob/master/CONTRIBUTING.md#issues is dead

[arunoda]

Yep. This is a bug.

[arunoda]

@mnmtanish This is suppose to work earlier. Seems like HMR dispose is not working properly. Isn't it?

[thani-sh]

@jzaefferer when calling storiesOf, are you giving module as the second argument? HMR dispose will work only if it's done. Example:

storiesOf('MyComponent', module)

[jzaefferer]

Yes, just verified that all our storiesOf calls pass module as the 2nd argument.

As far as I can tell, we're not doing anything out of the ordinary. Here's our config, webpack config and a sample story: https://gist.github.com/jzaefferer/e4c3152d60dd7e6537a1b72a6f6116dd

[thani-sh]

Thanks for the info. I'll check it out.

[thani-sh]

@arunoda this issue was there from the beginning. The order is lost when the module gets disposed and re-added. And when it's added again, it's added as a new component (kind) and so it goes to the end of the list.

Opened a PR for this issue:
#499

[thani-sh]

Fixed with #499

[jzaefferer]

Nice, thank you!