Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 15.4.0's performance profiling react_perf URL param doesn't work with Storybook #620

Closed
mnquintana opened this issue Nov 18, 2016 · 2 comments
Labels

Comments

@mnquintana
Copy link

React 15.4.0 introduced a way to profile components in the Timeline tab of Chrome DevTools with a new URL param, react_perf – I tried passing this to the storybook playground, but it doesn't seem to be passed down to the iframe components get loaded in. Is there a way to pass this param?

Steps to Reproduce

  1. Append ?react_perf to your local storybook server URL (e.g. localhost:6006/?react_perf) and visit that URL in a browser
  2. Open up DevTools, and record a Timeline of some action you want to profile (e.g. scrolling)

Expected

The Timeline view contains a User Timing label that shows the timeline of each component's updates.

Actual

There is no User Timing label in the timeline view.

Let me know if there's any more info you need! I'd also be happy to submit a PR to add support for this if you can point me in the right direction.

@mnquintana mnquintana changed the title Using React 15.4.0's performance profiling react_perf URL param doesn't work in Devtools React 15.4.0's performance profiling react_perf URL param doesn't work in Devtools Nov 18, 2016
@mnquintana mnquintana changed the title React 15.4.0's performance profiling react_perf URL param doesn't work in Devtools React 15.4.0's performance profiling react_perf URL param doesn't work with Storybook Nov 18, 2016
@arunoda
Copy link
Member

arunoda commented Nov 19, 2016

Yep. This is something we need to fix.

@arunoda
Copy link
Member

arunoda commented Nov 19, 2016

@mnquintana I try to do a fix here: #623
Since we render react-components in a iframe, I'm not sure it's getting that or not.

Could you check whether this works or not.
Try to play with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants