Can't perform shortcut when input is focused

[shilman]

Issue by willowcheng
Wednesday Apr 12, 2017 at 04:15 GMT
Originally opened as storybook-eol/storybook-ui#81

---

In #60, it was discussed to fix the bug as ⌘ ⇧ → and ⌘ ⇧ ← would trigger shortcut if <input> is focused. Along with the fix, it would also remove part of functionality of shortcut. Check this repo for minimal reproducing with auto focused <input>.

The first time I got into trouble was using shortcut to toggle search box, I couldn't dismiss it until it's unfocused.

[Hypnosphi]

I think it's OK to keep disabling shortcuts when some input is focused. The issue with search box is quite annoying though. We can allow dismissing it with Esc key and/or outside click. Maybe we could use ReactModal like it's done in shortcuts_help. "Toggle Search Box" should be renamed into "Show Search Box" in that case.