Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CSS files #93

Closed
ritz078 opened this issue Apr 11, 2016 · 7 comments
Closed

Separate CSS files #93

ritz078 opened this issue Apr 11, 2016 · 7 comments

Comments

@ritz078
Copy link
Contributor

ritz078 commented Apr 11, 2016

As the project starts getting bigger, it will make more sense to separate out CSS in different files. We are already using css-loader so that shouldn't be a problem. Also in future we will be able to use CSS feature like keyframe etc and at the same time make the project more modular.

@arunoda
Copy link
Member

arunoda commented Apr 11, 2016

Got it.
But, How that's relate to this project?
We allow to use any kind of CSS.

If this is related to this project, We use CSS in JS mostly. But, we need some cleanup for the use of CSS.

@ritz078
Copy link
Contributor Author

ritz078 commented Apr 11, 2016

when I was implementing transition on action, I couldn't use CSS's keyframe functionality as they can't be used with inline CSS. So instead I had to use setTimeout . Separating it will be better in the long run as it will remove any limitations.

@arunoda
Copy link
Member

arunoda commented Apr 11, 2016

@ritz078 got it.

It is possible for you to use keyframe functionality with Radium.
See: https://github.com/FormidableLabs/radium

If so, I'm happy to use that instead of setTimeout.

@jeef3
Copy link
Contributor

jeef3 commented Apr 11, 2016

Keyframes in Radium: https://github.com/FormidableLabs/radium/tree/master/docs/api#keyframes

Radium works really well, although I'm personally still undecided on the best CSS approach for use with React.

@arunoda
Copy link
Member

arunoda commented Apr 12, 2016

I agree with @jeef3 too.
CSS area where no one agrees with one tech.
I think, it will be like that.

@ritz078
Copy link
Contributor Author

ritz078 commented Apr 13, 2016

Thanks . I will go forward with the proposed solution.

@ritz078 ritz078 closed this as completed Apr 13, 2016
@arunoda
Copy link
Member

arunoda commented Apr 13, 2016

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants