Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken @storybook/addon-contexts types #9639

Closed
TeoTN opened this issue Jan 26, 2020 · 7 comments
Closed

Broken @storybook/addon-contexts types #9639

TeoTN opened this issue Jan 26, 2020 · 7 comments

Comments

@TeoTN
Copy link

TeoTN commented Jan 26, 2020

Describe the bug
Types for @storybook/addon-contexts@5.3.9 seem to be broken, causing following TypeScript error:

Could not find a declaration file for module '@storybook/addon-contexts/react'. '.../node_modules/@storybook/addon-contexts/react.js' implicitly has an 'any' type.
  Try `npm install @types/storybook__addon-contexts` if it exists or add a new declaration (.d.ts) file containing `declare module '@storybook/addon-contexts/react';`  TS7016

To Reproduce
import { withContexts } from '@storybook/addon-contexts/react';

Expected behavior
No errors

@sjwilczynski
Copy link
Contributor

Same issue for me

@iansan5653
Copy link

Using

import { withContexts } from '@storybook/addon-contexts/dist/preview/frameworks/react';

Works, but then TypeScript can't determine the type of the contexts argument because "Cannot find module '../../shared/types'."

@stale
Copy link

stale bot commented Feb 27, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Feb 27, 2020
@TeoTN
Copy link
Author

TeoTN commented Mar 9, 2020

I'd expect a way to get correct types without knowing internal structure of the library...

@stale stale bot removed the inactive label Mar 9, 2020
@shilman
Copy link
Member

shilman commented Mar 9, 2020

Looking to replace addon-contexts in SB6.0 with addon-toolbars that is much simpler and uses Storybook core features (args, decorators). Feedback welcome!

Open PR, API still under consideration: #10028

@stale
Copy link

stale bot commented Mar 30, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 30, 2020
@stale
Copy link

stale bot commented Apr 29, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants