Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: Add vue-cli example and remove babel-preset-vue #10821

Merged
merged 2 commits into from
May 19, 2020

Conversation

graup
Copy link
Contributor

@graup graup commented May 18, 2020

Issue: #10790 and #4475

What I did

  1. Added new example app, vue-cli. This is supposed to be a minimum working example using all the latest bells and whistles (typescript, class components, decorators). It is very similar to what someone gets when they run vue create.
  2. I also FINALLY removed babel-preset-vue from storybook. As discussed in framework-preset-vue requires babel-preset-vue but does not depend on it #4475 that is mostly obsolete and only needed for older apps. It is however needed for our vue-kitchen-sink example, so that gave me an immediate case to create a migration path, which is also included in this PR.
  3. These two changes are in the same PR because 1 depends on 2.
  4. Removed localIdentName option in vue-kitchen-sink webpack. It was throwing a warning and doesn't seem to be needed anyway.

How to test

  • example/vue-ci: yarn storybook and yarn serve
  • example/vue-kitchen-sink: yarn storybook and yarn dev

TODO

  • Document migration path
  • Change setup guide for vue (it's much easier now!) and remove references to babel-reset-vue, e.g. from here

graup added 2 commits May 19, 2020 00:09
See the vue-kitchen-sink app for a migration path.
Basically you just need to add the preset to your or storybook's babel config.
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @graup !! Merging 😍

@shilman shilman added vue maintenance User-facing maintenance tasks labels May 19, 2020
@shilman shilman changed the title vue-cli example and remove babel-preset-vue Vue: Add vue-cli example and remove babel-preset-vue May 19, 2020
@shilman shilman merged commit cb1a515 into storybookjs:mrmckeb/issue10790 May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants