Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix addon panel layout styling #1170

Merged
merged 2 commits into from
Jun 2, 2017
Merged

Fix addon panel layout styling #1170

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfaf4fb
Fix addon panel layout styling
zillding May 31, 2017
56e596f
Merge branch 'master' into master
ndelangen Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/ui/src/modules/ui/components/layout/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const downPanelStyle = downPanelInRight => ({
display: 'flex',
flexDirection: downPanelInRight ? 'row' : 'column',
alignItems: 'stretch',
position: 'absolute',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break scrolling inside the panel, I think?

I'm confused about this element being width & height : 100% AND also have padding..

Can you provide a reproducible case which caused you to find a problem you wanted to fix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops I missed the issue, I'm going have to try opening safari I guess 😃

width: '100%',
height: '100%',
padding: downPanelInRight ? '5px 10px 10px 0' : '0px 10px 10px 0',
Expand Down