Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for issue with stories panel #1689

Merged
merged 2 commits into from
Aug 20, 2017
Merged

Hotfix for issue with stories panel #1689

merged 2 commits into from
Aug 20, 2017

Conversation

Hypnosphi
Copy link
Member

Issue: once you hide the stories ("left") panel, you can't open it again. In fact, it doesn't even hide:
screen shot 2017-08-20 at 02 48 03
Related: #1614

Unfortunately, I overlooked those lines when reviewing #1598. Unfortunately, I can't figure out where this error get caught so that the failure is silent.

@igor-dv, I think it's better to use an additional state field instead of input ref there

@Hypnosphi Hypnosphi requested a review from a team August 20, 2017 00:05
@codecov
Copy link

codecov bot commented Aug 20, 2017

Codecov Report

Merging #1689 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1689      +/-   ##
==========================================
+ Coverage   20.87%   20.88%   +0.01%     
==========================================
  Files         251      251              
  Lines        5629     5631       +2     
  Branches      676      669       -7     
==========================================
+ Hits         1175     1176       +1     
- Misses       3933     3964      +31     
+ Partials      521      491      -30
Impacted Files Coverage Δ
...rc/modules/ui/components/left_panel/text_filter.js 34.66% <33.33%> (+0.42%) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-83.88%) ⬇️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b544ba...685aea5. Read the comment docs.

@@ -64,6 +64,10 @@ export default class TextFilter extends React.Component {
}

setInputRef(input) {
if (input == null) {
Copy link
Member

@igor-dv igor-dv Aug 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my fault.

@Hypnosphi Hypnosphi merged commit f15490e into master Aug 20, 2017
@Hypnosphi Hypnosphi deleted the stories-panel-hotfix branch August 20, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants