-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Fix url for all packages in package.json #22101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joeycozza once again, thanks for taking the time to put together yet another pull request and help us with not only our documentation but also the addon ecosystem. From my end, this is almost good to go. I left a small item for you to look into. I'll defer to @yannbf and see what he has to say so that we continue to work on this to get it to a point where we can merge it.
Looking forward to hearing from you.
Stay safe
Co-authored-by: Yann Braga <yannbf@gmail.com>
Co-authored-by: Yann Braga <yannbf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! Thank you so so much for your contributions @joeycozza !
@joeycozza sorry for the delayed response, I just checked, and it's good on my end. Thanks for addressing the feedback so promptly. Appreciate it 🙏 ! We'll get this one in soon. Hope you have a great weekend. Stay safe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect. Thank you so much for your contribution @joeycozza and sorry for the confusion! ❤️
Maintenance: Fix url for all packages in package.json
What I did
Mostly I updated the
homepage
andrepository.directory
fields in many package.json files to reflect the change when a handful of directories were moved into a newcode
directory.I also found a few broken links in some documentation so I updated them as well.
Also, updated
main
tonext
on most of the url changes with yannbf's guidanceHow to test
Try opening the old url, see it fail.
Try opening the new url, see it work.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]