Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addons: Remove deprecated addPanel use and misc improvements #23284

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Addons: Remove deprecated addPanel use and misc improvements #23284

merged 2 commits into from
Jul 3, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 3, 2023 •
edited
Loading

What I did

  • addon/a11y tests improvements
  • no addPanel use (deprecated)
  • addons should always have a type property
  • improve API for navigate
  • improve ergonomics of yarn task

How to test

  • unit tests should pass
  • running yarn tasks should work
  • check command should pass
  • no UI regressions for tabs

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen
minor code improvements
e6cbba7 
- a11y tests
- no addPanel use (deprecated)
- addons should always have a type
- improve API for navigate
- improve ergonomics of yarn task
@ndelangen ndelangen self-assigned this Jul 3, 2023
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Jul 3, 2023
@ndelangen ndelangen changed the title minor code improvements CodeQuality: Misc improvements Jul 3, 2023
@ndelangen ndelangen changed the title CodeQuality: Misc improvements Hygiene: Misc improvements Jul 3, 2023
@ndelangen
Copy link
Member Author

@shilman self-merging

@ndelangen ndelangen merged commit c1f399b into next Jul 3, 2023
@ndelangen ndelangen deleted the norbert/minor-improvements branch July 3, 2023 19:19
@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Merged
7 tasks
@shilman shilman added maintenance User-facing maintenance tasks and removed build Internal-facing build tooling & test updates labels Jul 4, 2023
@shilman shilman changed the title Hygiene: Misc improvements Addons: Remove deprecated addPanel use and misc improvements Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @shilman