Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte-Webpack: Support Svelte v4 #23336

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Svelte-Webpack: Support Svelte v4 #23336

merged 6 commits into from
Jul 10, 2023

Conversation

JReinhold
Copy link
Contributor

What I did

Expand version range in svelte-webpack5 and preset-svelte-webpack to support v4. This is a follow up PR to #22905, I simply forgot the Webpack side.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold changed the title expand svelte dep to 4.0.0 Svelte-Webpack: Support Svelte v4 Jul 6, 2023
@JReinhold JReinhold self-assigned this Jul 6, 2023
@JReinhold JReinhold mentioned this pull request Jul 6, 2023
Closed
@JReinhold JReinhold added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 6, 2023
@JReinhold JReinhold added the ci:daily Run the CI jobs that normally run in the daily job. label Jul 8, 2023
@socket-security
Copy link

socket-security bot commented Jul 8, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
svelte 4.0.0 None +12 2.97 MB svelte-admin

@JReinhold JReinhold requested a review from ndelangen July 10, 2023 07:35
@JReinhold JReinhold merged commit 5f58f5c into next Jul 10, 2023
@JReinhold JReinhold deleted the svelte-4-webpack branch July 10, 2023 13:25
This was referenced Jul 10, 2023
Merged
Merged
valentinpalkovic pushed a commit that referenced this pull request Jul 12, 2023
@JReinhold @valentinpalkovic
Merge pull request #23336 from storybookjs/svelte-4-webpack
b563dcd 
Svelte-Webpack: Support Svelte v4
(cherry picked from commit 5f58f5c)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 12, 2023
@adrukh adrukh mentioned this pull request Nov 27, 2023
Open
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@JReinhold JReinhold

Labels
ci:daily Run the CI jobs that normally run in the daily job. dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JReinhold @ndelangen