Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Essentials: Prototype removing addon-docs from addon-essentials #23479

Closed

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 17, 2023

What I did

  • refactored addon-essentials to be simpler, and more robust. No longer does it have files for porting the preview & manager & preset files of it's sub-addons.
  • adding preview.ts or manager.ts or preset.ts files in sub-addons will be auto added.
  • removed addon-docs from essentials
  • added addon-docs to sb init.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen requested a review from shilman July 19, 2023 08:40
@ndelangen ndelangen changed the title Essentials: No more docs addon in addon-essentials Essentials: Remove addon-docs from addon-essentials Jul 19, 2023
@shilman shilman changed the title Essentials: Remove addon-docs from addon-essentials Essentials: Prototype removing addon-docs from addon-essentials Jul 19, 2023
Base automatically changed from release/7.2 to next July 19, 2023 15:12
@ndelangen ndelangen closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants