Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Support v19 in react-dom-shim #26898

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Conversation

Tobbe
Copy link
Contributor

@Tobbe Tobbe commented Apr 20, 2024

What I did

I updated the React version check in @storybook/react-dom-shim to also support React version 19.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Update to the latest canary release of React
  2. Launch Storybook and open your browser's console
  3. Observe
    react-16.mjs:3 Uncaught (in promise) TypeError: react_dom__WEBPACK_IMPORTED_MODULE_0__.render is not a function
        at react-16.mjs:3:1
        at new Promise (<anonymous>)
        at renderElement (react-16.mjs:3:1)
        at chunk-HLWAVYOI.mjs:5:1
    
  4. Apply this PR and try again. The error should now go away and your stories should work again

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added bug react patch:yes Bugfix & documentation PR that need to be picked to main branch ci:merged Run the CI jobs that normally run when merged. labels Apr 21, 2024
Copy link

nx-cloud bot commented Apr 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f065b3f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JReinhold JReinhold changed the title react-dom-shim: Support React 19 React: Support v19 in react-dom-shim Apr 26, 2024
@JReinhold JReinhold added maintenance User-facing maintenance tasks and removed bug labels Apr 26, 2024
@JReinhold JReinhold merged commit 34f0c20 into storybookjs:next Apr 26, 2024
7 of 10 checks passed
storybook-bot pushed a commit that referenced this pull request Apr 26, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
@github-actions github-actions bot mentioned this pull request Apr 26, 2024
9 tasks
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💪

@Tobbe Tobbe deleted the tobbe-react-19 branch April 26, 2024 11:54
storybook-bot pushed a commit that referenced this pull request Apr 26, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request Apr 29, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request Apr 29, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request Apr 29, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request Apr 29, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request Apr 30, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request May 1, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request May 1, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request May 1, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request May 1, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request May 2, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request May 2, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request May 2, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request May 3, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
@github-actions github-actions bot mentioned this pull request May 3, 2024
44 tasks
storybook-bot pushed a commit that referenced this pull request May 4, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request May 4, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
storybook-bot pushed a commit that referenced this pull request May 5, 2024
React: Support v19 in `react-dom-shim`
(cherry picked from commit 34f0c20)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:merged Run the CI jobs that normally run when merged. maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants