Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix filters not being applied in WebKit #26949

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Core: Fix filters not being applied in WebKit #26949

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b959d3
add logs to try and debug flakiness
yannbf Apr 19, 2024
a092fed
get index AFTER setting filters is done
JReinhold Apr 25, 2024
3cbe01d
cleanup
JReinhold Apr 25, 2024
65c84db
cleanup
JReinhold Apr 25, 2024
cfe6e11
Merge branch 'next' into yann/investigate-safari-flakiness
JReinhold Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions code/lib/manager-api/src/modules/stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,17 +648,20 @@ export const init: ModuleFn<SubAPI, SubState> = ({
}
},
experimental_setFilter: async (id, filterFunction) => {
const { internal_index: index } = store.getState();
await store.setState({ filters: { ...store.getState().filters, [id]: filterFunction } });

if (index) {
await api.setIndex(index);
const { internal_index: index } = store.getState();

const refs = await fullAPI.getRefs();
Object.entries(refs).forEach(([refId, { internal_index, ...ref }]) => {
fullAPI.setRef(refId, { ...ref, storyIndex: internal_index }, true);
});
if (!index) {
return;
}
// apply new filters by setting the index again
await api.setIndex(index);

const refs = await fullAPI.getRefs();
Object.entries(refs).forEach(([refId, { internal_index, ...ref }]) => {
fullAPI.setRef(refId, { ...ref, storyIndex: internal_index }, true);
});
},
};

Expand Down Expand Up @@ -879,6 +882,7 @@ export const init: ModuleFn<SubAPI, SubState> = ({
},
init: async () => {
provider.channel?.on(STORY_INDEX_INVALIDATED, () => api.fetchIndex());

await api.fetchIndex();
},
};
Expand Down
Loading