Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add stories to main storybook from templates #28705

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 25, 2024

What I did

I added stories that we add to sandboxes to the main storybook.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.4 MB 76.4 MB 224 B -1.19 0%
initSize 198 MB 198 MB 229 B -1.17 0%
diffSize 121 MB 121 MB 5 B 1.35 0%
buildSize 7.6 MB 7.6 MB 0 B - 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B - 0%
buildSbPreviewSize 349 kB 349 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.47 MB 4.47 MB 0 B - 0%
buildPreviewSize 3.12 MB 3.12 MB 0 B - 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 8.1s 6.9s -1s -200ms -0.97 -17.3%
generateTime 23.6s 21.3s -2s -230ms -0.44 -10.4%
initTime 25.5s 22.5s -2s -999ms -0.3 -13.3%
buildTime 13.7s 13.7s -56ms -0.89 -0.4%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 8.1s 8.7s 581ms -0.31 6.7%
devManagerResponsive 5.4s 5.7s 265ms -0.3 4.6%
devManagerHeaderVisible 841ms 883ms 42ms -0.16 4.8%
devManagerIndexVisible 872ms 919ms 47ms -0.13 5.1%
devStoryVisibleUncached 1.4s 1.1s -253ms -1.1 -21.9%
devStoryVisible 918ms 943ms 25ms -0.15 2.7%
devAutodocsVisible 757ms 865ms 108ms 0.51 12.5%
devMDXVisible 734ms 834ms 100ms 0.44 12%
buildManagerHeaderVisible 733ms 760ms 27ms -0.69 3.6%
buildManagerIndexVisible 738ms 767ms 29ms -0.68 3.8%
buildStoryVisible 789ms 831ms 42ms -0.55 5.1%
buildAutodocsVisible 735ms 636ms -99ms -1.29 🔰-15.6%
buildMDXVisible 722ms 746ms 24ms -0.01 3.2%

@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Jul 25, 2024
@ndelangen ndelangen self-assigned this Jul 25, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request integrates template stories into the main Storybook configuration and updates several dependencies for better flexibility and coverage.

  • code/.storybook/main.ts: Added new story directories and updated existing ones to include template stories, enhancing organization and coverage.
  • code/.storybook/preview.tsx: Removed globalTypes export; added new decorators and loaders for global styles and theme-based rendering.
  • code/addons/links/package.json: Updated @storybook/csf dependency to ^0.1.11 for more flexible versioning.
  • code/core/package.json: Changed @storybook/csf dependency to ^0.1.11 to allow minor and patch updates.
  • code/lib/blocks/package.json: Updated @storybook/csf dependency to ^0.1.11 for better dependency management.

10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d9b1fa6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen merged commit 141d8a2 into next Jul 25, 2024
58 of 61 checks passed
@ndelangen ndelangen deleted the norbert/add-template-stories branch July 25, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant