Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-storyshots): Remove excess slashes from jest transform warning #9616

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

callumacrae
Copy link
Contributor

It's printing all of them, so I copied all of them, and that didn't work!

before:

image

What I did

How to test

Testable by running storyshots tests with this config:

import initStoryshots, { multiSnapshotWithOptions } from '@storybook/addon-storyshots';

initStoryshots({
  test: multiSnapshotWithOptions()
});

Then if you're using CSFs, the warning will be thrown.

The example in the docs is already correct.

It's printing all of them, so I copied all of them, and that didn't work!
@vercel
Copy link

vercel bot commented Jan 23, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@shilman shilman added addon: storyshots bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 23, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@shilman shilman added this to the 5.3.x milestone Jan 23, 2020
@shilman shilman merged commit f1b1a28 into storybookjs:next Jan 23, 2020
@callumacrae callumacrae deleted the patch-3 branch January 24, 2020 09:40
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 2, 2020
shilman added a commit that referenced this pull request Feb 2, 2020
fix(addon-storyshots): Remove excess slashes from jest transform warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: storyshots bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants