Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] --watch is no longer effective #163

Closed
jasikpark opened this issue Aug 17, 2022 · 2 comments
Closed

[Bug] --watch is no longer effective #163

jasikpark opened this issue Aug 17, 2022 · 2 comments
Labels
bug Something isn't working linear

Comments

@jasikpark
Copy link

jasikpark commented Aug 17, 2022

Describe the bug

When running npx test-storybook --watch the test runner runs in normal mode, rather than watching for changes and exists on completion

Steps to reproduce the behavior

Bug encountered in a private repo, is there a good starter project I can test deps on?

Expected behavior

I'd expect --watch to watch for file changes and rerun test-storybook accordingly

Screenshots and/or logs

If applicable, add screenshots and/or logs to help explain your problem.

Environment

  • OS: macOS
  • Node.js version: v16.16.0
  • NPM version: v8.15.0
 "@storybook/test-runner": "^0.6.0-next.1",
 "@storybook/testing-library": "^0.0.13",
 "@storybook/testing-react": "^1.3.0",
 "jest": "^28.1.3",

Additional context

Add any other context about the problem here.

associated discord thread: https://discord.com/channels/486522875931656193/1006156600022667345/1006157098318577714

I think I may have discovered it being due to upgrading to jest 28 in our repo?

@jasikpark jasikpark added the bug Something isn't working label Aug 17, 2022
@jasikpark jasikpark changed the title [Bug] --watch no longer is effective [Bug] --watch is no longer effective Aug 17, 2022
@yannbf yannbf added the linear label Aug 22, 2022
@jasikpark
Copy link
Author

yay https://github.com/storybookjs/test-runner/releases/tag/v0.6.0-next.3

@yannbf
Copy link
Member

yannbf commented Aug 23, 2022

Fix was released in v0.6.0! Thanks once again @jasikpark

@yannbf yannbf closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linear
Projects
None yet
Development

No branches or pull requests

2 participants