Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition on latest logged action. #80

Merged
merged 3 commits into from
Apr 9, 2016
Merged

Transition on latest logged action. #80

merged 3 commits into from
Apr 9, 2016

Conversation

ritz078
Copy link
Contributor

@ritz078 ritz078 commented Apr 7, 2016

More details in #51

.join('\n\n');

return (<ActionLogger actionLog={log} onClear={clearLogs} />);
return (<ActionLogger data={data} onClear={clearLogs} />);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here do not send the whole data, but just send an array of strings. We can do it like this:

export function getActionLogger(data) {
  const { actions = [] } = data;
  const logs = actions
    .map(action => stringify(action, null, 2));

  return (<ActionLogger logs={logs} onClear={clearLogs} />);
}

@arunoda arunoda merged commit 27d7f94 into storybookjs:master Apr 9, 2016
@arunoda
Copy link
Member

arunoda commented Apr 9, 2016

Thanks.

@ritz078 ritz078 deleted the fix/log-transition branch April 9, 2016 18:44
@shilman shilman added the misc label May 27, 2017
ndelangen pushed a commit that referenced this pull request Feb 23, 2024
Copy link

nx-cloud bot commented Jun 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 27d7f94. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants