Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove typings for @storybook/addon-notes #1344

Merged

Conversation

joscha
Copy link
Member

@joscha joscha commented Jun 22, 2017

@codecov
Copy link

codecov bot commented Jun 22, 2017

Codecov Report

Merging #1344 into release/3.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.2    #1344   +/-   ##
============================================
  Coverage        13.76%   13.76%           
============================================
  Files              202      202           
  Lines             4621     4621           
  Branches           598      507   -91     
============================================
  Hits               636      636           
- Misses            3473     3548   +75     
+ Partials           512      437   -75
Impacted Files Coverage Δ
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
app/react/src/demo/Welcome.js 0% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 33.33% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6faea...f4b3df3. Read the comment docs.

@joscha joscha mentioned this pull request Jun 22, 2017
2 tasks
@shilman shilman changed the base branch from master to release/3.2 June 23, 2017 07:17
@shilman
Copy link
Member

shilman commented Jun 23, 2017

FYI I've changed the base branch to release/3.2 because this is not a patch change.

@shilman shilman modified the milestone: v3.2.0 Jun 23, 2017
@joscha
Copy link
Member Author

joscha commented Jun 23, 2017

The DefinitelyTyped package has been released, can I merge this into the 3.2 branch @ndelangen @shilman?

@shilman shilman merged commit f2241b4 into storybookjs:release/3.2 Jun 23, 2017
@joscha joscha deleted the joscha/remove-addon-notes-types branch June 23, 2017 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants