fix react runtime for addons in manager #19226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
So when a user has local addons, which are injecting a managerEntry, those are bundled by esbuild.
ESbuild should bundle JSX the way it's expected in the manager (which as of now is using react 16.
What I did
Add config to esbuild to ensure react runtime for addons is always as expected by the manager
I also removed the filter that removed the react internals exports..
We should not be using them, but it seems removing them breaks some things as well..
How to test