Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing README.md example for addons/info #1960

Merged
merged 3 commits into from
Oct 3, 2017

Conversation

moaxaca
Copy link
Contributor

@moaxaca moaxaca commented Oct 3, 2017

Issue:

What I did

Fixed a minor syntax error in addon/info/README.md

How to test

Markdown error no testing needed.

Does this need a new example in the kitchen sink apps?
No

Does this need an update to the documentation?
No

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #1960 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1960   +/-   ##
=======================================
  Coverage   21.38%   21.38%           
=======================================
  Files         262      262           
  Lines        5757     5757           
  Branches      696      691    -5     
=======================================
  Hits         1231     1231           
- Misses       3994     3995    +1     
+ Partials      532      531    -1
Impacted Files Coverage Δ
lib/codemod/src/transforms/update-addon-info.js 51.16% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/left_panel.js 25.71% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b763a...0396e4d. Read the comment docs.

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Hypnosphi Hypnosphi self-assigned this Oct 3, 2017
@moaxaca
Copy link
Contributor Author

moaxaca commented Oct 3, 2017

Rebased to stay up to date. Caught this when setting up the config for my company.

@Hypnosphi Hypnosphi merged commit 66374a7 into storybookjs:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants