Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Create a generate task and use in the sandbox process #19840

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Build: Create a generate task and use in the sandbox process #19840

merged 6 commits into from
Nov 21, 2022

Conversation

tmeasday
Copy link
Member

Issue: using local repros was a painful process with many steps

What I did

  • Move template=>repro generation into a task step
  • Use that as a dependency of sandbox for inDevelopment tasks
  • Hopefully update scripts appropriately

How to test

Try

yarn task --task sandbox --template cra/default-js --start-from install --no-link

@tmeasday tmeasday added the build Internal-facing build tooling & test updates label Nov 15, 2022
@tmeasday tmeasday requested review from shilman and yannbf November 15, 2022 09:15
shilman
shilman approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @tmeasday !! This will make adding new frameworks/templates SOO much easier

@tmeasday tmeasday merged commit 8fb754a into next Nov 21, 2022
@tmeasday tmeasday deleted the tom/sb-787-add---no-degit-option-to-repro-next-and branch November 21, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@yannbf yannbf Awaiting requested review from yannbf

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman