Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Use typescript legacy templates until our ecosystem fully supports ts 4.9 #20032

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Maintenance: Use typescript legacy templates until our ecosystem fully supports ts 4.9 #20032

merged 1 commit into from
Nov 30, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 30, 2022

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added maintenance User-facing maintenance tasks typescript labels Nov 30, 2022
@yannbf yannbf requested a review from kasperpeulen November 30, 2022 16:10
kasperpeulen
kasperpeulen approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasperpeulen kasperpeulen merged commit 0591b61 into next Nov 30, 2022
@kasperpeulen kasperpeulen deleted the chore/always-use-ts-legacy-templates branch November 30, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannbf @kasperpeulen