Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typescript.checkOptions not a valid interface #20166

Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Dec 8, 2022

Issue: #19731

What I did

I fixed and cleaned up a few typings in core-common

I found a way to gain access to the correct interface from ForkTsCheckerWebpackPlugin
that should address the reported bug, I think

@ndelangen ndelangen self-assigned this Dec 8, 2022
@ndelangen ndelangen requested a review from tmeasday December 8, 2022 16:10
@ndelangen ndelangen changed the title Norbert/sb-919-sb19731-typescriptcheckoptions-has-been Fix: typescript.checkOptions not a valid interface Dec 8, 2022
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmeasday tmeasday merged commit 0cb361f into next Dec 8, 2022
@tmeasday tmeasday deleted the norbert/sb-919-sb19731-typescriptcheckoptions-has-been branch December 8, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants