Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update moment from 2.19.0 to 2.19.1 in addons/knobs #2026

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

dependencies[bot]
Copy link

@dependencies dependencies bot commented Oct 12, 2017

moment has been updated to 2.19.1 in addons/knobs by dependencies.io

2.19.1

  • Release Oct 11, 2017

Make react native and webpack both work

@codecov
Copy link

codecov bot commented Oct 12, 2017

Codecov Report

Merging #2026 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2026   +/-   ##
=======================================
  Coverage   21.34%   21.34%           
=======================================
  Files         262      262           
  Lines        5767     5767           
  Branches      695      701    +6     
=======================================
  Hits         1231     1231           
+ Misses       4005     3991   -14     
- Partials      531      545   +14
Impacted Files Coverage Δ
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.97% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 33.33% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 32% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429f387...655bd73. Read the comment docs.

Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.19.0 is broken so we should definitely require 2.19.1

@danielduan
Copy link
Member

fixes #2006

@danielduan danielduan merged commit 6dc4424 into master Oct 12, 2017
@danielduan danielduan deleted the moment-2.19.1-22.0.0-addons--knobs branch October 12, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants