Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF-tools: Fix ConfigFile string literal property handling #20785

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 25, 2023

Issue: N/A

What I did

I noticed that some automigrations were failing in the sandboxes repo (yay automigration.log file), and the reason is that the generated main.js contains a format which was unsupported in the new getNameFromPath function in csf-tools. This PR fixes that.

How to test

This is covered in unit tests, but feel free to compile CLI and run sb automigrate in a sandbox

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf requested a review from shilman January 25, 2023 14:27
@shilman shilman changed the title csf-tools: fix getNameFromPaths in string literal obj property CSF-tools: Fix ConfigFile string literal property handling Jan 25, 2023
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great catch!

@yannbf yannbf merged commit c3a7637 into next Jan 25, 2023
@yannbf yannbf deleted the fix/csf-tools-name-from-path branch January 25, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants