fix: Storybook does not respect BROWSER env var #21473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook does not respect BROWSER env var if default browser is not chromium based. This commit adds a check for the environment variable, and passes it to the open package as an argument if the specified browser is not chromium based. Closes #21343
ndelangen
approved these changes
Mar 14, 2023
|
Great work @thtliife ! We'll be merging this after 7.0 is released! |
|
Awesome thanks @ndelangen 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storybook does not respect BROWSER env var if default browser is not chromium based.
Closes #21343
What I did
This commit adds a check for the environment variable, and passes it to the open package as an argument if the specified browser is not chromium based.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]