Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1013 autoload all *.stories.js files in cli templates #2195

Merged
merged 5 commits into from
Oct 31, 2017

Conversation

danielduan
Copy link
Member

Issue:

#1013 we should try to autoload all *.stories.js to make user's lives easier

What I did

How to test

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@danielduan danielduan added the cli label Oct 31, 2017
@danielduan danielduan added this to the v3.3.0 milestone Oct 31, 2017
Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CLI snapshots by running yarn test --cli --update

@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

Merging #2195 into release/3.3 will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #2195      +/-   ##
===============================================
- Coverage        21.73%   21.69%   -0.05%     
===============================================
  Files              356      356              
  Lines             7071     7072       +1     
  Branches           925      902      -23     
===============================================
- Hits              1537     1534       -3     
- Misses            4835     4869      +34     
+ Partials           699      669      -30
Impacted Files Coverage Δ
...est/snapshots/angular-cli/stories/index.stories.js 0% <0%> (ø)
...t/snapshots/react_project/stories/index.stories.js 0% <0%> (ø)
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
addons/info/src/components/types/OneOfType.js 11.11% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.63% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 9.09% <0%> (ø) ⬆️
addons/knobs/src/base.js 2.38% <0%> (ø) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42e4c1...1d0d679. Read the comment docs.

@danielduan
Copy link
Member Author

I don't think the CLI test is set up right. Either that, or the angular storybook doesn't work. Looks like there's a lot of missing dependencies

@Hypnosphi
Copy link
Member

Hypnosphi commented Oct 31, 2017

Snapshot update should work anyway, it runs before smoke tests

Please just run yarn test --cli --update and commit whichever files are changed after that (even though the command itself eventually exits with non-zero code)

UPD: nevermind, I can see you already did that

@Hypnosphi Hypnosphi merged commit f051082 into release/3.3 Oct 31, 2017
@Hypnosphi Hypnosphi deleted the dd/auto-import branch October 31, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants