Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Use vite 4.3 beta in sandboxes #21986

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Vite: Use vite 4.3 beta in sandboxes #21986

merged 2 commits into from
Apr 11, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Apr 6, 2023

Closes #

What I did

This updates our sandboxes to use the latest vite beta versions, to get some experience working with it and help surface any issues now before the release, hopefully.

We'll need to change it back after vite 4.3 stable is released.

How to test

CI should pass successfully. If it doesn't, we'll need to investigate why.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kylegach kylegach added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 10, 2023
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 11, 2023
@shilman shilman merged commit 42ddc9a into next Apr 11, 2023
@shilman shilman deleted the vite-beta branch April 11, 2023 14:24
@github-actions
Copy link
Contributor


Fails
🚫 A 'patch' label is required to merge during stabilization.

Patch PRs are small bug fixes, build updates, and documentation changes.
They do not include new features or more disruptive bugfixes.

These changes will be first released on 7.1-alpha, then patched back to 'main'
after they have been verified to be correct and released as 7.0.x patch releases.

After the stabilization period ends (ETA 2023-04-12), the 'patch' label
will no longer be required to merge into next, and we will merge ALL accepted
PRs to 'next' and release them on 7.1-alpha. Patch PRs will be
patched back to 'main' and released in 7.0.x patch releases.

Generated by 🚫 dangerJS against e707a27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants