Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Fix url for all packages in package.json #22101

Merged
merged 6 commits into from
May 1, 2023
Merged

Maintenance: Fix url for all packages in package.json #22101

merged 6 commits into from
May 1, 2023

Conversation

joeycozza
Copy link
Contributor

@joeycozza joeycozza commented Apr 14, 2023

What I did

Mostly I updated the homepage and repository.directory fields in many package.json files to reflect the change when a handful of directories were moved into a new code directory.

I also found a few broken links in some documentation so I updated them as well.

Also, updated main to next on most of the url changes with yannbf's guidance

How to test

Try opening the old url, see it fail.
Try opening the new url, see it work.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeycozza once again, thanks for taking the time to put together yet another pull request and help us with not only our documentation but also the addon ecosystem. From my end, this is almost good to go. I left a small item for you to look into. I'll defer to @yannbf and see what he has to say so that we continue to work on this to get it to a point where we can merge it.

Looking forward to hearing from you.

Stay safe

MIGRATION.md Outdated Show resolved Hide resolved
@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 21, 2023
joeycozza and others added 2 commits April 21, 2023 11:05
Co-authored-by: Yann Braga <yannbf@gmail.com>
Co-authored-by: Yann Braga <yannbf@gmail.com>
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! Thank you so so much for your contributions @joeycozza !

@yannbf yannbf added maintenance User-facing maintenance tasks and removed documentation labels Apr 21, 2023
@yannbf yannbf changed the title fixing urls pointing to source code to include "code" in path Maintenance: Fix url for all packages in package.json Apr 21, 2023
@jonniebigodes
Copy link
Contributor

@joeycozza sorry for the delayed response, I just checked, and it's good on my end. Thanks for addressing the feedback so promptly. Appreciate it 🙏 ! We'll get this one in soon.

Hope you have a great weekend.

Stay safe

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect. Thank you so much for your contribution @joeycozza and sorry for the confusion! ❤️

@yannbf yannbf merged commit d9bf860 into storybookjs:next May 1, 2023
@joeycozza joeycozza deleted the fixingGithubUrls branch May 1, 2023 15:10
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 3, 2023
shilman pushed a commit that referenced this pull request May 3, 2023
Maintenance: Fix url for all packages in package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants