improve sandboxes commit message #22136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
force-pushed
the
feat/improve-sandboxes-commit-message
branch
from
92b9335
to
30189e6
Compare
- display merged PRs between sandbox updates - display a link to the diff
This reverts commit 12b1422.
yannbf
force-pushed
the
feat/improve-sandboxes-commit-message
branch
from
30189e6
to
f68e8a5
Compare
JReinhold
approved these changes
Apr 18, 2023
yannbf
added
the
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Apr 24, 2023
…mit-message improve sandboxes commit message
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR provides an improved commit message whenever we generate sandboxes, so it's easier to debug or investigate what happened at the moment of a sandbox being updated.
How to test
We can only properly test this after merged or if we force an update to the sandboxes after there are actual sandbox changes. Tricky!
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]