Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon-actions: Fix type of withActions #22455

Merged
merged 2 commits into from
May 17, 2023
Merged

Conversation

kasperpeulen
Copy link
Contributor

Closes #22384

What I did

Make sure the withActions type is properly using generics.

How to test

Try this new type in this repro:
https://github.com/JeffreyStevens/addon-actions.git

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen merged commit 454b69f into next May 17, 2023
@ndelangen ndelangen deleted the kasper/fix-decorator-type branch May 17, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
3 participants