Sandboxes: Pin @vitejs/plugin-react to avoid conflict #22501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22454
Closes #22294
What I did
This fixes the issue that is currently preventing contributors from being able to create vite-react sandboxes without
--no-link
. The problem is that we use@vitejs/plugin-react@3
in@storybook/react-vite
, but new vite projects are created in the sandboxes using the latest version 4.This addresses the problem by adding a
resolutions
in the sandbox that pins the version to^4.0.0
. We don't use the backup version supplied in react-vite, so this does not have any impact on how we use the sandbox, and it doesn't impact everyday Storybook users either.How to test
Run
yarn task --task sandbox --template react-vite/default-ts --start-from install
, it should succeed.Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]