Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix pnpm init command #22635

Merged
merged 1 commit into from
May 19, 2023
Merged

CLI: Fix pnpm init command #22635

merged 1 commit into from
May 19, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 19, 2023

Closes #

What I did

Turns out -y is not a known flag to pnpm init! It's not an interactive command like in npm, therefore I removed it!

How to test

  1. On an empty dir, run pnpm init -y, watch it fail
  2. Now run pnpm init, watch it succeed!

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch reported labels May 19, 2023
@shilman shilman merged commit 5338442 into next May 19, 2023
@shilman shilman deleted the fix/pnpm-init-command branch May 19, 2023 16:38
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 22, 2023
shilman added a commit that referenced this pull request May 22, 2023
@shilman shilman mentioned this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch reported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants