Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Add custom pipes support #2518

Merged
merged 3 commits into from
Dec 20, 2017
Merged

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Dec 19, 2017

Issue: #2514

What I did

Added pipes array to story definition to provide custom pipes to the NgModule

How to test

TBD

@codecov
Copy link

codecov bot commented Dec 19, 2017

Codecov Report

Merging #2518 into release/3.3 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/3.3   #2518      +/-   ##
==============================================
- Coverage        19.51%   19.5%   -0.01%     
==============================================
  Files              386     386              
  Lines             8706    8709       +3     
  Branches           928     951      +23     
==============================================
  Hits              1699    1699              
+ Misses            6320    6283      -37     
- Partials           687     727      +40
Impacted Files Coverage Δ
addons/knobs/src/angular/helpers.js 0% <0%> (ø) ⬆️
addons/info/src/components/types/Signature.js 16.66% <0%> (ø) ⬆️
addons/actions/src/lib/index.js 7.14% <0%> (ø) ⬆️
...ents/stories_panel/stories_tree/tree_decorators.js 34.37% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
addons/info/src/components/types/proptypes.js 16.66% <0%> (ø) ⬆️
addons/actions/src/lib/types/nan/index.js 29.41% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 51.85% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20828c6...4d8e769. Read the comment docs.

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only approve from a code-practice point of view, I have no idea if this change makes sense, I do not know angular well enough.

Feel free to merge if you're sure this is the right thing to do.

@igor-dv
Copy link
Member Author

igor-dv commented Dec 20, 2017

@alterx has approved on slack as well.

@igor-dv igor-dv merged commit cb34518 into release/3.3 Dec 20, 2017
@igor-dv igor-dv deleted the angular-support-custom-pipes branch December 20, 2017 04:54
@shilman shilman mentioned this pull request Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants