Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test that angular example works #2557

Merged
merged 3 commits into from
Dec 24, 2017
Merged

CI: test that angular example works #2557

merged 3 commits into from
Dec 24, 2017

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Dec 24, 2017

Later we can add an integration test as well
did that

@codecov
Copy link

codecov bot commented Dec 24, 2017

Codecov Report

Merging #2557 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2557   +/-   ##
=======================================
  Coverage   32.69%   32.69%           
=======================================
  Files         398      398           
  Lines        8837     8837           
  Branches      941      967   +26     
=======================================
  Hits         2889     2889           
+ Misses       5310     5271   -39     
- Partials      638      677   +39
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
...ddons/actions/src/containers/ActionLogger/index.js 49.25% <0%> (ø) ⬆️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
addons/actions/src/lib/types/nan/index.js 82.35% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 40% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 24.21% <0%> (ø) ⬆️
lib/codemod/src/transforms/move-buildin-addons.js 46.87% <0%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e485708...52fc7fc. Read the comment docs.

@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label Dec 24, 2017
@ndelangen ndelangen merged commit 89d8801 into master Dec 24, 2017
@ndelangen ndelangen deleted the CI-angular branch December 24, 2017 11:27
@ndelangen
Copy link
Member

Great catch @Hypnosphi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants