Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guide for Angular #2574

Merged
merged 6 commits into from
Dec 27, 2017
Merged

Conversation

Quramy
Copy link
Contributor

@Quramy Quramy commented Dec 27, 2017

Issue:
There is no guide for Angular.

What I did

Write angular-guide.


## Starter Guide Angular

Storybook has its own Webpack setup and a dev server.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An initial letter should be a lowercase letter;)
see: https://github.com/webpack/media#name

@codecov
Copy link

codecov bot commented Dec 27, 2017

Codecov Report

Merging #2574 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2574   +/-   ##
=======================================
  Coverage   32.68%   32.68%           
=======================================
  Files         398      398           
  Lines        8838     8838           
  Branches      953      954    +1     
=======================================
  Hits         2889     2889           
+ Misses       5313     5282   -31     
- Partials      636      667   +31
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/configs/handle_routing.js 24.21% <0%> (ø) ⬆️
lib/components/src/table/table.js 83.33% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReviver.js 71.42% <0%> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 79.31% <0%> (ø) ⬆️
addons/actions/src/lib/types/nan/index.js 82.35% <0%> (ø) ⬆️
addons/a11y/src/components/WrapStory.js 72.09% <0%> (ø) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c13fb...cd6aaaa. Read the comment docs.

@kazupon
Copy link
Member

kazupon commented Dec 27, 2017

LGTM 👍
/ping @alterx

@alterx
Copy link
Member

alterx commented Dec 27, 2017

LGTM, my only concern is that is dones't touch on any of the specifics but as a quick guide I think it shouldn't

@ndelangen
Copy link
Member

Thank you @Quramy !! 🙇

@Hypnosphi Hypnosphi merged commit a13f39b into storybookjs:master Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants