Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all peerDependencies for apps. #2601

Merged
merged 1 commit into from
Dec 28, 2017

Conversation

alansouzati
Copy link

What I did

Fixed all peerDependencies to avoid using single pipe (this is an invalid syntax and issues npm install warnings)

How to test

Install apps and make sure there is no warning in the console

Is this testable with jest or storyshots?

No.

Does this need a new example in the kitchen sink apps?

No.

Does this need an update to the documentation?

No.

@Hypnosphi Hypnosphi added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 28, 2017
@alansouzati
Copy link
Author

Any idea why circle ci failed?

@Hypnosphi
Copy link
Member

Hypnosphi commented Dec 28, 2017

Nevermind, some config trouble. It's an optional check anyway

@Hypnosphi Hypnosphi merged commit ce993cc into storybookjs:master Dec 28, 2017
shilman pushed a commit that referenced this pull request Jan 7, 2018
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants