Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html and markup loaders to angular and vue apps #2692

Merged
merged 3 commits into from
Jan 9, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Jan 8, 2018

Issue: html and markup loaders are used in vue/angular apps but are not listed in package json

What I did

Added them to package.json

CC: @amcdnl

@codecov
Copy link

codecov bot commented Jan 8, 2018

Codecov Report

Merging #2692 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2692   +/-   ##
=======================================
  Coverage   34.35%   34.35%           
=======================================
  Files         389      389           
  Lines        8747     8747           
  Branches      905      911    +6     
=======================================
  Hits         3005     3005           
+ Misses       5143     5139    -4     
- Partials      599      603    +4
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
app/react/src/demo/Welcome.js 64.7% <0%> (ø) ⬆️
addons/events/src/components/Event.js 38.55% <0%> (ø) ⬆️
addons/actions/src/lib/util/prepareArguments.js 57.14% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
addons/knobs/src/angular/utils.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/withLifecycleDecorator.js 17.14% <0%> (ø) ⬆️
lib/codemod/src/transforms/move-buildin-addons.js 46.87% <0%> (ø) ⬆️
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b18e1...9872b76. Read the comment docs.

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igor-dv igor-dv self-assigned this Jan 9, 2018
@igor-dv igor-dv added vue angular patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 9, 2018
@Hypnosphi
Copy link
Member

@ndelangen how is node security check configured? It seems to be hung

@igor-dv igor-dv merged commit 903aa0e into master Jan 9, 2018
@igor-dv igor-dv deleted the apps-missed-loaders branch January 9, 2018 16:36
shilman added a commit that referenced this pull request Jan 10, 2018
Add html and markup loaders to angular and vue apps
@Hypnosphi Hypnosphi added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants