-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel 7 #3746
Conversation
Woo!! Can't wait for this to land. Anything we can do to help? |
Thanks @vicapow, I hope to be able to finish this in upcoming days |
LGTM @igor-dv |
Done - #4062 |
Will you publish a new alpha version containing this? |
@shilman shall we release an alpha version today? |
I tried this release to make Storybook work with React Native 0.56.0 but I always have a message about unallowed presets. Is there something to change in our project ? A working example somewhere ? The error message I have when starting Storybook :
|
We didn't migrate React Native part yet |
OK, thanks for your response. Any idea when it will be migrated ? |
Definitely not before Expo and Create React Native App both support RN 0.56 with Babel 7 |
fyi RN 0.57 (in rc) supports babel 7 |
@chrisnojima 0.56 does as well. But Create React Native App and Expo don't |
@Hypnosphi I can't see any plan for that in issues of Create React Native App. Do you have informations about that ? Or do you know a workaround for this ? Our project doesn't use Create React Native App / Expo and Storybook is our last step to migrate to RN 0.56. Really a problem for us :( |
@Gongreg any ideas? |
I just saw migrating to RN 0.56.0 is not a priority for Expo team : https://blog.expo.io/expo-sdk-v29-0-0-is-now-available-f001d77fadf Absolutely no chance to see Storybook React Native migrating to Babel 7 before CRNA and Expo do it ? |
Probably needs delaying: #3746 (comment)
DISCLAIMER: this is about moving Storybook build process itself to Babel 7, and making it the default. You should be able to use Babel 7 in your app with current stable version of Storybook, you just need to install babel-bridge
Issue: #3335
This doesn't yet fix all the issues linked from there but it performs the necessary breaking change so that rest of the work could be done in a minor release