-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(bug) Fix Select array values showing k (fixes #4560) #4586
Conversation
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #4586 +/- ##
==========================================
+ Coverage 35.57% 35.59% +0.01%
==========================================
Files 557 557
Lines 6732 6732
Branches 884 884
==========================================
+ Hits 2395 2396 +1
+ Misses 3877 3876 -1
Partials 460 460
Continue to review full report at Codecov.
|
I was planning on fixing this today, thank you so much @diagramatics! 🙇 |
@diagramatics @ndelangen it still does not work on 4.0.0 |
would be great to get this into a release! |
@chrisbutler, check out #4560 (comment) |
@chrisbutler @Drapegnik @DanielG2002 missed this. will get out another release today @ndelangen please tag with |
(bug) Fix Select array values showing k (fixes #4560)
weird, this was merged before 4.0 release |
@Hypnosphi I released from the |
Issue: #4560
Turns out the assignment of
k
in a shorthand notation of an object waswrong. Using
k
instead of[k]: k
makes it assign to parameter key'k'
as opposed to whatk
as a variable contains.This is testable with Jest. The added test covers this bug.