Allow for angular-devkit/core version aligned with Angular v7 #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
reviewed
Oct 30, 2018
Codecov Report
@@ Coverage Diff @@
## master #4652 +/- ##
=======================================
Coverage 35.59% 35.59%
=======================================
Files 557 557
Lines 6732 6732
Branches 884 884
=======================================
Hits 2396 2396
Misses 3876 3876
Partials 460 460Continue to review full report at Codecov.
|
emilio-martinez
force-pushed
the
feat/angular-v7
branch
from
9d136ed
to
0f6b9f6
Compare
emilio-martinez
changed the title
igor-dv
approved these changes
Oct 31, 2018
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Set @storybook/angular's peer dependency range to allow for Angular ^7.0.0. There's a test fixture for it already. Additionally, I was able to successfully run and build Storybook v4 with a Angular CLI v7-generated project.
This change simply removes the peer dependency warning when installing @storybook/angular.
How to test
There's a test fixture for it already.