Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set zone.js as a peer and dev dependency #4663

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

emilio-martinez
Copy link
Contributor

Issue: #4641

What I did

Set zone.js as a peer and dev dependency for @storybook/angular.

How to test

Behavior shouldn't change since Storybook should be pulling the version of zone.js already being used in Angular projects anyway.

"zone.js": "^0.8.26"
},
"devDependencies": {
"zone.js": "^0.8.26"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kroeder should we add zone.js in cli?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean when running sb init? No, there's no angular without zone.js installed. ng new my-app already does add zone.js, angular does not work without it - We do not need to take care of this

https://medium.com/@MertzAlertz/what-the-hell-is-zone-js-and-why-is-it-in-my-angular-2-6ff28bcf943e

Let’s do an experiment. Go and take your favorite Angular 2 app, and don’t include zone.js. See what happens, I’ll wait here. Notice anything interesting? None of the bindings are working!

@emilio-martinez
Copy link
Contributor Author

CLI tests seem to have tripped while testing Vue

Module build failed (from ./node_modules/vue-loader/index.js):
TypeError: Cannot read property 'vue' of undefined

@igor-dv
Copy link
Member

igor-dv commented Oct 31, 2018

Yes. I see this error in master. will check

@codecov
Copy link

codecov bot commented Nov 3, 2018

Codecov Report

Merging #4663 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4663   +/-   ##
=======================================
  Coverage   35.59%   35.59%           
=======================================
  Files         557      557           
  Lines        6732     6732           
  Branches      884      884           
=======================================
  Hits         2396     2396           
  Misses       3876     3876           
  Partials      460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729bc9c...2424fec. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants