Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font family to info panel #5759

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

mateoholman
Copy link
Contributor

Issue: #5723

What I did

Add the same font family to the info panel that is used by the outer panels.

How to test

Use the info addon. I tested with the cra-kitchen-sink example. Previously, the info panel did not have the same font family as the outer panel(s).

  • Is this testable with Jest or Chromatic screenshots? Possibly
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Feb 26, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@mateoholman
Copy link
Contributor Author

mateoholman commented Feb 26, 2019

Should I update the related snapshot tests for this, or wait until after initial review?

@shilman
Copy link
Member

shilman commented Feb 26, 2019

@mateoholman Thanks for the quick fix on this! Please update the snapshots and we'll get it merged.

@shilman shilman added this to the v5.0.0 milestone Feb 26, 2019
@vercel vercel bot requested a deployment to staging February 26, 2019 23:10 Abandoned
@vercel
Copy link

vercel bot commented Feb 26, 2019

You are pushing commits at a very fast pace (accross the whole organization).
Due to that, we cannot deploy the commit 0470c9d.

You can try again later or upgrade your plan.

@vercel vercel bot requested a deployment to staging February 26, 2019 23:22 Abandoned
@vercel
Copy link

vercel bot commented Feb 26, 2019

You are pushing commits at a very fast pace (accross the whole organization).
Due to that, we cannot deploy the commit c2df59f.

You can try again later or upgrade your plan.

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #5759 into next will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             next   #5759      +/-   ##
=========================================
+ Coverage   33.48%   33.5%   +0.01%     
=========================================
  Files         647     647              
  Lines        9419    9400      -19     
  Branches     1367    1339      -28     
=========================================
- Hits         3154    3149       -5     
+ Misses       5644    5633      -11     
+ Partials      621     618       -3
Impacted Files Coverage Δ
addons/info/src/components/Story.js 88.34% <ø> (ø) ⬆️
lib/ui/src/core/init-provider-api.js 21.42% <0%> (-4.38%) ⬇️
addons/knobs/src/registerKnobs.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b2f79...c2df59f. Read the comment docs.

@mateoholman
Copy link
Contributor Author

@shilman I thought I updated the appropriate snapshots, but looks like some checks are still failing? This is my first contribution, so let me know if I'm missing something 🤷‍♂️ . Thanks!

@ndelangen ndelangen self-assigned this Feb 27, 2019
@ndelangen
Copy link
Member

tested locally, all is good

@ndelangen ndelangen merged commit 1cfc04c into storybookjs:next Feb 27, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 1, 2019
shilman pushed a commit that referenced this pull request Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: info bug patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants