-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add font family to info panel #5759
Add font family to info panel #5759
Conversation
This pull request is automatically deployed with Now. |
Should I update the related snapshot tests for this, or wait until after initial review? |
@mateoholman Thanks for the quick fix on this! Please update the snapshots and we'll get it merged. |
0470c9d
to
c2df59f
Compare
Codecov Report
@@ Coverage Diff @@
## next #5759 +/- ##
=========================================
+ Coverage 33.48% 33.5% +0.01%
=========================================
Files 647 647
Lines 9419 9400 -19
Branches 1367 1339 -28
=========================================
- Hits 3154 3149 -5
+ Misses 5644 5633 -11
+ Partials 621 618 -3
Continue to review full report at Codecov.
|
@shilman I thought I updated the appropriate snapshots, but looks like some checks are still failing? This is my first contribution, so let me know if I'm missing something 🤷♂️ . Thanks! |
tested locally, all is good |
Issue: #5723
What I did
Add the same font family to the info panel that is used by the outer panels.
How to test
Use the info addon. I tested with the cra-kitchen-sink example. Previously, the info panel did not have the same font family as the outer panel(s).
If your answer is yes to any of these, please make sure to include it in your PR.